feat(mysql): support ZEROFILL column attribute #6400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fixes #6399 |
tobymao
reviewed
Nov 24, 2025
nian0114
force-pushed
the
main
branch
2 times, most recently
from
0d7321a to
cd8b35c
Compare
sqlglot/dialects/mysql.py
Outdated
Comment on lines
35
to
38
| class ZeroFill(exp.Expression): | ||
| pass | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
We shouldn't define new expression types outside of expressions.py. Please move this to said module and define it as ZeroFillColumnConstraint(ColumnConstraint): arg_types = {}, instead.
Contributor
Author
There was a problem hiding this comment.
aha ok. i will do it later.
sqlglot/dialects/mysql.py
Outdated
| exp.Year: _remove_ts_or_ds_to_date(), | ||
| exp.UtcTimestamp: rename_func("UTC_TIMESTAMP"), | ||
| exp.UtcTime: rename_func("UTC_TIME"), | ||
| ZeroFill: lambda self, e: "ZEROFILL", |
Collaborator
There was a problem hiding this comment.
The generation for ZeroFill needs to be moved to the base Generator class, otherwise doing sql() on a MySQL AST will raise, if it contains a ZEROFILL constraint.
This fixes parsing errors encountered when processing legacy MySQL schemas containing numeric columns with the zerofill property.
georgesittas
approved these changes
Nov 25, 2025
Collaborator
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Perfect, thank you for the swift iterations!
georgesittas
pushed a commit
that referenced
this pull request
Nov 25, 2025
This fixes parsing errors encountered when processing legacy MySQL schemas containing numeric columns with the zerofill property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_parse_typesinMySQL.Parserto consume theZEROFILLtoken and store it in the DataType expression.datatype_sqlinMySQL.Generatorto outputZEROFILLwhen the attribute is present.This fixes parsing errors encountered when processing legacy MySQL schemas containing numeric columns with the zerofill property.